Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: better differentiation between image_id and sprite_ids #1491

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

CommanderStorm
Copy link
Collaborator

made sure that the differences between image and sprite ids is clearer

The rationale is that I got stuck here for a bit and got quite confused.
After reading the sourcecode, this was much clear.

I am a bit too explicite on purpose, feel free to (ask to) revert/reduce/rewrite as you see fit. Docs are never written alone ^^

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nyurik nyurik merged commit 554ee0f into maplibre:main Aug 30, 2024
2 checks passed
@CommanderStorm CommanderStorm deleted the better branch August 30, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants