Warn on unknown cfg, CI cleanup #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Detect all unrecognized config file values, and report them. Ideally we want to use `serde-ignored` crate, but it doesn't work with flattened structs (yet). So using a bad workaround. * CI test has been using all sorts of somewhat duplicated temporary pbf files - cleaned up to `tmp.pbf`, and made sure curl only shows errors, not download stats. * Don't serialize optional config values as nulls * Tiny error message cleanup
lseelenbinder
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde-ignoredcrate, but it doesn't work with flattened structs (yet). So using a bad workaround.tmp.pbf, and made sure curl only shows errors, not download stats.