Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate DB init and tests #463

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Consolidate DB init and tests #463

merged 1 commit into from
Oct 28, 2022

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 25, 2022

  • Add justfile to simplify running all the tests
  • Save all PBF outputs to the text files
  • Consolidate all tests to reuse the same code
  • Consolidate database initialization
  • updated readme with the new instructions

Note that while this PR creates "expected" files, the CI cannot validate the generated results because the output is not stable. Eventually we may try to output just the non-geometry values to have reasonable tests comparing against the expected results.

@nyurik nyurik force-pushed the out-diff branch 2 times, most recently from 7c30b69 to 57f0a75 Compare October 26, 2022 12:50
* Add justfile to simplify running all the tests
* Save all PBF outputs to the text files
* Consolidate all tests to reuse the same code
* Consolidate database initialization
* updated readme with the new instructions
@nyurik nyurik changed the title Automate output verification Consolidate DB init and tests Oct 28, 2022
Copy link
Member

@lseelenbinder lseelenbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nyurik nyurik merged commit a0a411f into maplibre:main Oct 28, 2022
@nyurik nyurik deleted the out-diff branch October 28, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants