Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlx-rustls support #720

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Add sqlx-rustls support #720

merged 3 commits into from
Jul 3, 2023

Conversation

pka
Copy link
Contributor

@pka pka commented Jun 20, 2023

I'd like to add optional rustls support for SQLx. This PR implements the required features, but tests using --all-features fail, because runtime selection features are not additive. I didn't find a solution apart from avoiding --all-features.

@nyurik
Copy link
Member

nyurik commented Jun 20, 2023

@pka welcome!!! #474 tried to do something similar. I would LOVE to switch to rustls, but PostgreSQL is a major pain to switch, sadly... Some day...

Anyway, I am ok to remove all the all-features - we don't really need that. Instead, we should use more specific targets that we know we support

@sharkAndshark sharkAndshark marked this pull request as ready for review June 21, 2023 00:23
@nyurik nyurik force-pushed the sqlx-rustls branch 4 times, most recently from feea593 to 4a9cc26 Compare July 3, 2023 18:12
@nyurik nyurik enabled auto-merge (squash) July 3, 2023 18:13
@wipfli
Copy link

wipfli commented Jul 3, 2023

Hi @pka, welcome...

@nyurik nyurik merged commit aabcb0a into maplibre:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants