add tls connection envs #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 45.25% 45.58% +0.32%
==========================================
Files 13 13
Lines 1328 1358 +30
==========================================
+ Hits 601 619 +18
- Misses 727 739 +12
Continue to review full report at Codecov.
|
stepankuzmin
requested changes
Jun 7, 2020
There was a problem hiding this comment.
Hi @kapcsandi and thanks for the PR! I really appreciate your work, but could you please fix these minor comments? You may also add some tests for this if you'd like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can set extra tls connection options with theese environment variables: