-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop V8::AdjustAmountOfExternalAllocatedMemory usage unless it helps perf #136
Milestone
Comments
Going to remove this finally. My reasoning is:
|
benjamn
added a commit
to meteor/node-fibers
that referenced
this issue
Dec 30, 2019
Apparently calling v8::Isolate::AdjustAmountOfExternalAllocatedMemory frequently results in lots of wasted CPU cycles on garbage collection, per discussion here: meteor/meteor#10527 (comment) This fix was inspired by marudor/libxmljs2#22, which seems to have addressed nodejs/node#30995. Another project that benefitted from adjusting external allocated memory less often: mapnik/node-mapnik#136
benjamn
pushed a commit
to meteor/meteor
that referenced
this issue
Dec 30, 2019
Apparently calling v8::Isolate::AdjustAmountOfExternalAllocatedMemory frequently results in lots of wasted CPU cycles on garbage collection, per discussion here: #10527 (comment) This fix was inspired by marudor/libxmljs2#22, which seems to have addressed nodejs/node#30995. Another project that benefitted from adjusting external allocated memory less often: mapnik/node-mapnik#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We give V8 memory hints with
V8::AdjustAmountOfExternalAllocatedMemory
, but because this function has to be called from the main loop, and because calling it is not always cheap, it may not be worth it. We don't have hard evidence that telling v8 about memory usage outside its heap actually prevents meltdowns/over mem usage, it is just precautionary.Also, if we remove these calls, then we also don't need to do anything about #119
The text was updated successfully, but these errors were encountered: