Implement gzip compression in the C++ layer #456
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change goes towards #413, adding
options so that vtile compression can be done in the C++ layer, rather than passing full data out to NodeJS.
Points to review:
not clear on all the return types, do they need to be wrapped inNanEscapeScope()
?_gzip_compress
, is there a better place to put this?_gzip_compress
, are they appropriate in C++-world?