Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gzip compression in the C++ layer #456

Closed
wants to merge 7 commits into from

Conversation

danpat
Copy link
Contributor

@danpat danpat commented May 29, 2015

This change goes towards #413, adding

tile.getData({compression: 'gzip', level:9, strategy:"DEFAULT"});

options so that vtile compression can be done in the C++ layer, rather than passing full data out to NodeJS.

Points to review:

  • not clear on all the return types, do they need to be wrapped in NanEscapeScope()?
  • private method _gzip_compress, is there a better place to put this?
  • data types passed to and returned from _gzip_compress, are they appropriate in C++-world?

@springmeyer
Copy link
Member

going to close this up now. I've manually integrated this work into #505 - thanks @danpat!

@springmeyer springmeyer closed this Sep 8, 2015
@springmeyer springmeyer modified the milestones: v3.4.6, v3.5.0 Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants