Build on windows against stock node v4 and v6 #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 42 42
Lines 8810 8810
=======================================
Hits 8478 8478
Misses 332 332Continue to review full report at Codecov.
|
springmeyer
force-pushed
the
win-test-dane
branch
from
9f680b4
to
59bb577
Compare
|
This is working now: we are building cleanly against the stock node v0.10, 4, 6, and 8 on windows. Going to merge this into master. |
Closed
springmeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves build on appveyor to use the normal (aka stock) node.exe from nodejs.org (installed using appveyor shortcuts).
TODO: