Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split mapnik_image.cpp #812

Closed
wants to merge 1 commit into from
Closed

Conversation

talaj
Copy link
Member

@talaj talaj commented Sep 18, 2017

As per #806 (comment), this splits mapnik_image.cpp into these files:

src/mapnik_image.cpp
src/mapnik_image_clear.cpp
src/mapnik_image_composite.cpp
src/mapnik_image_copy.cpp
src/mapnik_image_encode.cpp
src/mapnik_image_fill.cpp
src/mapnik_image_filter.cpp
src/mapnik_image_from_buffer.cpp
src/mapnik_image_from_bytes.cpp
src/mapnik_image_open.cpp
src/mapnik_image_premultiply.cpp
src/mapnik_image_resize.cpp
src/mapnik_image_save.cpp
src/mapnik_image_solid.cpp
src/mapnik_image_svg.cpp

mapnik_vector_tile.cpp will follow in a separate pull request.

@flippmoke
Copy link
Member

I think this is a great PR and was planning on merging if we resolve the merge conflicts.

@springmeyer
Copy link
Member

Anyone have bandwidth to resolve the conflicts and get this merged?

@artemp
Copy link
Member

artemp commented Apr 27, 2020

@talaj - your original idea lives on in N-API port #946, thanks!
/cc @springmeyer

@artemp artemp mentioned this pull request Aug 4, 2020
@springmeyer
Copy link
Member

#946 landed in master now as v4.5.1

@springmeyer springmeyer closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants