Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all keyboard shortcuts in option dropdown menu active #2144

Merged
merged 8 commits into from
Nov 13, 2023

Conversation

CollinBeczak
Copy link
Collaborator

No description provided.

@CollinBeczak
Copy link
Collaborator Author

CollinBeczak commented Oct 28, 2023

Goals: Shortcuts should be unavailable when rapid editor is open always.

Current problems with branch:

  1. Going from classic mode to rapid editor does not remove the custom event listeners, so the shortcuts are still active.
  2. Pause Keyboard shortcuts have no effect on event listeners, so shortcuts stay active threw those listeners.
  3. Resume keyboard shortcuts likely also doesnt have the functionality needed to add back those event listeners that were removed from pausing once pausing is fixed.

Needed Solutions:

  1. Fix deactivated keyboard shortcuts (Currently not removing event listeners).
  2. Fix Pause keyboard shortcuts to deactivate event listeners, and resume keyboard shortcuts to reactivate event listeners.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #2144 (099e4de) into main (8bec650) will decrease coverage by 0.11%.
Report is 13 commits behind head on main.
The diff coverage is 3.92%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   24.71%   24.61%   -0.11%     
==========================================
  Files         644      644              
  Lines       22100    22087      -13     
  Branches     6796     6809      +13     
==========================================
- Hits         5463     5436      -27     
- Misses      13921    13934      +13     
- Partials     2716     2717       +1     
Files Coverage Δ
...OCs/WithKeyboardShortcuts/WithKeyboardShortcuts.js 11.76% <ø> (+2.24%) ⬆️
...TaskAlreadyFixedControl/TaskAlreadyFixedControl.js 50.00% <ø> (-7.90%) ⬇️
...ontrols/TaskCompletionStep2/TaskCompletionStep2.js 9.37% <ø> (ø)
...skFalsePositiveControl/TaskFalsePositiveControl.js 50.00% <ø> (-6.53%) ⬇️
...eTaskControls/TaskFixedControl/TaskFixedControl.js 41.66% <ø> (-10.51%) ⬇️
...iveTaskControls/TaskSkipControl/TaskSkipControl.js 25.00% <ø> (+9.21%) ⬆️
...kControls/TaskTooHardControl/TaskTooHardControl.js 50.00% <ø> (-7.90%) ⬇️
...ts/Widgets/TaskMapWidget/RapidEditor/EditSwitch.js 0.00% <0.00%> (ø)
...skDetails/ActiveTaskControls/ActiveTaskControls.js 2.27% <4.00%> (+0.68%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@CollinBeczak CollinBeczak marked this pull request as draft October 30, 2023 20:23
@CollinBeczak CollinBeczak marked this pull request as ready for review November 8, 2023 21:26
@jschwarz2030 jschwarz2030 merged commit 0260d7f into main Nov 13, 2023
jschwarz2030 pushed a commit that referenced this pull request Nov 14, 2023
* make all keyboard shortcuts in option dropdown menu active

* add no existent props handler

* fix completion modal shortcuts to disable when rapid editor is open

* add prevent default to remove reboard shortcut initially typing in text box

* remove quickkeyhandler

* combine duplicate code

* fix editmode undefined

* change function name
@ljdelight ljdelight deleted the keyboardShortcutsFix branch November 15, 2023 04:57
CollinBeczak added a commit that referenced this pull request Nov 27, 2023
* make all keyboard shortcuts in option dropdown menu active

* add no existent props handler

* fix completion modal shortcuts to disable when rapid editor is open

* add prevent default to remove reboard shortcut initially typing in text box

* remove quickkeyhandler

* combine duplicate code

* fix editmode undefined

* change function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants