Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 18, 20, 21 #2182

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Support Node 18, 20, 21 #2182

merged 10 commits into from
Nov 30, 2023

Conversation

jschwarz2030
Copy link
Contributor

Notable upgrades
react-scripts v4 -> v5

Removing and replacing libraries that are not considered browser-compatible by react-scripts v5

  • @mapbox/geojsonhint
  • parse-link-header

All other upgrades and changes were for the purpose of node-18/react-scriptsv5 compatibility

Testing libraries were all upgraded and jest-environment-jsdom-sixteen was dropped completely as no longer needed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (fb9fa87) 24.63% compared to head (4d78f26) 23.80%.

Files Patch % Lines
src/services/Mapillary/Mapillary.js 0.00% 11 Missing and 3 partials ⚠️
src/interactions/GeoJSON/AsValidatableGeoJSON.js 0.00% 7 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2182      +/-   ##
==========================================
- Coverage   24.63%   23.80%   -0.83%     
==========================================
  Files         646      646              
  Lines       22179    22192      +13     
  Branches     6829     6832       +3     
==========================================
- Hits         5463     5283     -180     
- Misses      13989    14148     +159     
- Partials     2727     2761      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschwarz2030 jschwarz2030 changed the title Support Node 18 Support Node 18, 20, 21 Nov 26, 2023
@jschwarz2030 jschwarz2030 merged commit 5aa7157 into main Nov 30, 2023
jschwarz2030 added a commit that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants