Prevent "ghost widget" from appearing in workspace widget layout editor #2361
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from rendering a resize element in the workspace layout editor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2268. The problem:
If a widget is both "permanent" to a default workspace layout (can't be removed) but also "conditional", in that it is sometimes hidden based on certain conditions, the widget will not appear in a workspace but the layout editor will render an empty resize element that can't be moved or removed:
In this case (and currently the only case), it is the Tag Diff widget that appears conditionally when a task is cooperative/Tag Fix task:
The solution:
Since the desired behavior is that certain widgets be permanent (can't be removed from) but only shown under certain conditions, an inline css style rule applied in this circumstance will prevent the empty resize element from appearing in the layout editor view.