Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bundling issues related to created status #2387

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Jul 22, 2024

Issue: When users who are not the mapper view a task in a created state that is also in a bundle, the frontend attempts to delete the bundle.

Solution: Remove the condition that allows this behavior and prevent bundles from being removed on the frontend when they were not successfully deleted on the backend.

Extra:

  • Fix the resizing of maps. Previously, when a user resized a widget, the map content was based on the original height and width when the widget loaded.
  • Prevent tasks that are already in a bundle from being lassoed or selected in the "Work on Multiple Tasks" widget.

@CollinBeczak CollinBeczak force-pushed the fix-bundling-issues-related-to-created-status branch from 43ac559 to 4126203 Compare July 22, 2024 01:59
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 5.30973% with 107 lines in your changes missing coverage. Please review.

Project coverage is 23.49%. Comparing base (8520ba6) to head (66b7005).

Files Patch % Lines
...c/components/HOCs/WithTaskBundle/WithTaskBundle.js 0.00% 62 Missing and 13 partials ⚠️
...s/WithTaskClusterMarkers/WithTaskClusterMarkers.js 0.00% 3 Missing and 2 partials ⚠️
.../components/TaskAnalysisTable/TaskAnalysisTable.js 0.00% 2 Missing and 3 partials ⚠️
src/components/InsetMap/InsetMap.js 0.00% 4 Missing ⚠️
src/components/TaskPane/TaskMap/TaskMap.js 0.00% 4 Missing ⚠️
...omponents/TaskPane/TaskNearbyList/TaskNearbyMap.js 0.00% 4 Missing ⚠️
src/components/SupplementalMap/SupplementalMap.js 25.00% 3 Missing ⚠️
src/services/Task/Task.js 0.00% 3 Missing ⚠️
...ChallengeTaskClusters/WithChallengeTaskClusters.js 0.00% 0 Missing and 2 partials ⚠️
...ents/Widgets/TaskBundleWidget/TaskMarkerContent.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   23.49%   23.49%   -0.01%     
==========================================
  Files         651      651              
  Lines       22553    22579      +26     
  Branches     6937     6939       +2     
==========================================
+ Hits         5298     5304       +6     
- Misses      14437    14451      +14     
- Partials     2818     2824       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as ready for review July 24, 2024 17:49
@CollinBeczak CollinBeczak marked this pull request as draft August 6, 2024 19:57
@CollinBeczak CollinBeczak marked this pull request as ready for review August 9, 2024 17:56
@CollinBeczak CollinBeczak force-pushed the fix-bundling-issues-related-to-created-status branch from 8ee5bb4 to 66b7005 Compare August 12, 2024 14:22
Copy link
Contributor

@jschwarz2030 jschwarz2030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, will merge and suggest thorough testing in staging

@CollinBeczak CollinBeczak merged commit 04832eb into main Aug 12, 2024
5 of 6 checks passed
@CollinBeczak CollinBeczak deleted the fix-bundling-issues-related-to-created-status branch August 12, 2024 18:44
@CollinBeczak CollinBeczak mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants