Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empy mr tag bug #2413

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix empy mr tag bug #2413

merged 2 commits into from
Sep 3, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Issue: An empty mr tag was being added on task completion whenever a task was submitted without any mr tags.

This pr solves that issue by preventing a null value from being passed the endpoint that saves tags.
Before fix:
Screenshot 2024-08-15 at 6 00 18 PM
After fix:
Screenshot 2024-08-15 at 5 59 34 PM

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.37%. Comparing base (95dca9d) to head (e997d23).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/ReviewTaskControls/ReviewTaskControls.js 0.00% 1 Missing and 1 partial ⚠️
...skDetails/ActiveTaskControls/ActiveTaskControls.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   23.38%   23.37%   -0.01%     
==========================================
  Files         649      649              
  Lines       22514    22515       +1     
  Branches     6902     6918      +16     
==========================================
  Hits         5264     5264              
+ Misses      14425    14424       -1     
- Partials     2825     2827       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak merged commit 76c2980 into main Sep 3, 2024
5 of 6 checks passed
@CollinBeczak CollinBeczak deleted the CollinBeczak/Fix-empy-mr-tag-bug branch September 3, 2024 18:31
@CollinBeczak CollinBeczak mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant