fix infinite loading screen on challenge browse page #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-low
approved these changes
Oct 3, 2024
CollinBeczak
deleted the
fix-infinite-loading-screen-on-challenge-browse-page
branch
|
@CollinBeczak It does not seem to be resolved yet. Force clearing cache does not help. |
|
@danieldegroot2 Sorry for the confusion. This fix hasn't been deployed to production yet. Now that it's landed in the main branch it will definitely be included in the next release, which we are hoping to create and deploy early next week. |
Merged
|
@danieldegroot2 this has now been deployed. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where, when the user is signed out, the challenge browse page loads infinitely.
The issue occurred because we retrieve the owner ID from the challenge data. Previously, users were required to be logged in with proper authentication to access certain high-load endpoints. If a user wasn’t logged in, the system would return an empty array. Since this empty array lacked the owner object, the UI failed to meet the conditions needed to move past the loading spinner, causing the bug."