Delete dead code #2473
Merged
Delete dead code #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-low
force-pushed
the
jlow/dead-code
branch
from
a264e1d
to
d377154
Compare
|
LGTM |
CollinBeczak
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran some scripts to find and delete unused JS modules. Many of the dead source code modules appear to be leftovers from MapRoulette v2, which were copy-pasted into this project at the beginning of its Git history but never used. Some others were used in parts of the UI that have been removed or rewritten.
I also found and removed all of the translation strings that were unused (or only used in modules that I deleted).