Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify loading of localization strings #2483

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jake-low
Copy link
Contributor

  • simplifies the code that loads translated strings
  • removes some unused imports - we were pulling in @formatjs/intl-relativetimeformat but not using it; today the browser can format dates natively using Intl.DateTimeFormat and Intl.RelativeTimeFormat.
  • removes localization strings for language names - as explained in the code comment in Locale.js, it's better if these strings are not localized so that a user can recognize the name of their own language in the list even when the interface is set to a language they don't understand.

Copy link
Collaborator

@CollinBeczak CollinBeczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jake-low jake-low merged commit 8f7f0a6 into main Oct 29, 2024
6 checks passed
@jake-low jake-low deleted the jlow/simplify-localization-loading branch October 29, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants