Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classifier container to allow pipeline to go straight to inference #280

Merged
merged 19 commits into from
Nov 10, 2023

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Oct 27, 2023

Summary

This PR fixes #275 in two ways:

  • Adds method to create a dataloader from a PatchDataset.
  • Adds the ability to create a ClassifierContainer without defining a dataloader. Datasets can then be added using the load_dataset() method.

Fixes #275

Describe your changes

  • Add create_dataloaders() method to PatchDataset
  • Require model and labels_map or load_path
  • Only require criterion for training/validation

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 changed the title Dev classify Update classifier container to allow straight to inference Oct 27, 2023
@rwood-97 rwood-97 changed the title Update classifier container to allow straight to inference Update classifier container to allow pipeline to go straight to inference Oct 27, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rwood-97 rwood-97 merged commit e2f2027 into main Nov 10, 2023
3 checks passed
@rwood-97 rwood-97 deleted the dev_classify branch November 10, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to load classifier container with no datasloaders/labels map
1 participant