Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not compatible with iOS from April 2020 #2746

Closed
chris087 opened this issue Mar 5, 2020 · 9 comments
Closed

Plugin is not compatible with iOS from April 2020 #2746

chris087 opened this issue Mar 5, 2020 · 9 comments

Comments

@chris087
Copy link

chris087 commented Mar 5, 2020

This plugin uses the uiwebview, which is not supported by Apple from April 2020.
@see: https://ionicframework.com/blog/understanding-itms-90809-uiwebview-api-deprecation/

The plugin must be updated to use WKWebView.

@wf9a5m75
Copy link
Member

wf9a5m75 commented Mar 5, 2020

This plugin also supports WKWebView on ionic.

@mcastets
Copy link

mcastets commented Mar 5, 2020

Yep. But actions are required by the end of 2020 for existing apps and by April 2020 for new apps using this plugin.

Every plugin should understand the new config.xml preference tag: <preference name="WKWebViewOnly" value="true" /> introduced with cordova-ios@5.0.1.

References to UIWebView must be removed from the source.

See also other plugins such as InAppBrowser which are taking actions: apache/cordova-plugin-inappbrowser#584

@wf9a5m75
Copy link
Member

wf9a5m75 commented Mar 5, 2020

Ah, I see. Please send a pull request.

@EinfachHans
Copy link
Contributor

Anyone working on a PR? Otherwise i will, as the Changes seems not to be that hard?

@mcastets
Copy link

mcastets commented Mar 10, 2020

Anyone working on a PR?

I don't have enough Objective-C background to do so but I could try based on what have been done on InAppBrowser plugin. The main strategy seems to add a condition on every places containing the UiWebView keyword if WkWebViewOnly preference is present.

(Edit : I just had a look at your PR, it looks good to me, thank you for the great work. We should wait for a review)

@wf9a5m75
Copy link
Member

The PR has been merged on the multiple_maps branch.

@wf9a5m75
Copy link
Member

The cordova-plugin-googlemaps version 2.7.0 has been released.

@battika
Copy link
Member

battika commented Apr 4, 2020

Thanks Masashi.

@wf9a5m75
Copy link
Member

wf9a5m75 commented Apr 4, 2020

Sorry for late action.

@wf9a5m75 wf9a5m75 closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants