feat: Add compile-time decision for disabling UIWebView #584

beevelop · 2019-11-27T16:47:10Z

This PR fixes #583.

With the introduction of the WK_WEB_VIEW_ONLY flag, references to UIWebView are removed from the source. I tried to adapt the same changes from apache/cordova-ios#715 to this project.

ath0mas · 2019-11-28T09:53:03Z

Tried your fork, with and without "WKWebViewOnly" preference, and it's OK for me
💯

** BUILD SUCCEEDED **

@beevelop you didn't change references in plugin.xml as you suggested? and indeed I think it would prevent plugin to install or build correctly when not using "WKWebViewOnly" preference?

beevelop · 2019-11-28T10:13:02Z

Thank you for the feedback.

Yeah, modifying the plugin.xml is not necessary when using the compile-time approach. This way, we also stay backwards compatible.

ath0mas · 2019-12-02T09:57:35Z

Please, any update from team to review/merge this? And possible release 😇 ?

mjamal4u · 2019-12-03T19:31:36Z

Please, any update from team to review/merge this? And possible release 😇 ?

We are also in same pool. Would be great help if we can have early release :)

bbialas · 2019-12-10T08:53:05Z

@beevelop any chances to merge this one soon?

beevelop · 2019-12-10T09:27:21Z

@bbialas Unfortunately, I'm not in charge.
Maybe @breautek, @janpio or @NiklasMerz can help with that?

NiklasMerz · 2019-12-10T10:41:05Z

I am not an Apache Commiter, too. Since I still got no warning from Apple after uploading an app I did not test the flag, yet.

@dpa99c You are an expert for in app browser.

breautek · 2019-12-10T13:24:12Z

Sorry @beevelop I generally stay away from iOS pull requests because I don't have personal apple hardware to use for testing, and I'm not very experienced in objective-c either.

But i can say that PRs won't get merged into until all checks passes. Currently it is failing for what appears to be an issue with the tests getting a webview context.

No webview context. Retries remaining: 2
cordova-paramedic: Tests failed to complete; ending session. The error is:
Error: [context("WEBVIEW_5906.1")] Error response status: 21, Timeout - An operation did not complete before its timeout expired. Selenium error: Automation Server Error -- Selenium didn't complete your last command on time.
For help, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages

https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/617811060?utm_medium=notification&utm_source=github_status

My educated guess tells me this is because the tests are probably trying to run in a cordova-ios environment without a wkwebview plugin installed. But not 100% sure if this is the case.

beevelop · 2019-12-10T15:48:56Z

@breautek The builds are failing due to an error in the pipelines. They are not exactly related to the changes in this PR. See #491 or compare to #528 (CI checks also failed). Not quite sure, on how to proceed there.

ath0mas · 2019-12-11T09:04:41Z

@breautek how to/can we rerequest check suite?

Kepro · 2019-12-18T17:43:19Z

c'mon guys! you can do it! cannot wait for fix :) like really cannot wait :D

Kepro · 2019-12-19T09:48:41Z

hey, I tried these changes locally but now I got CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.

ath0mas · 2019-12-20T08:33:39Z

@Kepro more context or log or a minimal reproducible example is needed to understand your problem

Kepro · 2019-12-20T08:39:59Z

@ath0mas hi there, sorry!
"cordova-ios": "5.1.1" (latest)
cordova-plugin-inappbrowser: 3.1.0 (latest)

2019-12-20 09:36:38.164820+0100 XXX532:103173] Apache Cordova native platform version 5.1.1 is starting.
2019-12-20 09:36:38.167505+0100 XXX[532:103173] Multi-tasking -> Device: YES, App: YES
2019-12-20 09:36:38.184551+0100 XXX[532:103173] [CDVTimer][console] 0.204921ms
2019-12-20 09:36:38.185113+0100 XXX[532:103173] [CDVTimer][handleopenurl] 0.293016ms
2019-12-20 09:36:38.193607+0100 XXX[532:103173] [CDVTimer][intentandnavigationfilter] 8.319974ms
2019-12-20 09:36:38.194196+0100 XXX[532:103173] [CDVTimer][gesturehandler] 0.292063ms
2019-12-20 09:36:38.227851+0100 XXX[532:103173] [CDVTimer][file] 33.380032ms
2019-12-20 09:36:38.229283+0100 XXX[532:103173] [CDVTimer][inappbrowser] 1.068950ms
2019-12-20 09:36:38.229725+0100 XXX[532:103173] CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.
2019-12-20 09:36:38.229895+0100 XXX[532:103173] [CDVTimer][uiinappbrowser] 0.292897ms
2019-12-20 09:36:38.230252+0100 XXX[532:103173] [CDVTimer][wkinappbrowser] 0.262022ms
2019-12-20 09:36:38.246181+0100 XXX[532:103173] [CDVTimer][splashscreen] 15.802026ms
2019-12-20 09:36:38.262580+0100 XXX[532:103173] [CDVTimer][statusbar] 16.147971ms
2019-12-20 09:36:38.264041+0100 XXX[532:103173] [CDVTimer][localstorage] 1.145959ms
2019-12-20 09:36:38.264271+0100 XXX[532:103173] [CDVTimer][TotalPluginStartup] 80.597043ms

Kepro · 2019-12-20T11:23:46Z

okay, it now complains about it but it's working together with cordova-plugin-wkwebview-engine in config.xml

			<!-- Cordova WKWebView engine  -->
			<preference name="WKWebViewOnly" value="true" />
			<preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
			<feature name="CDVWKWebViewEngine">
				<param name="ios-package" value="CDVWKWebViewEngine" />
			</feature>

debug

2019-12-20 12:19:12.953981+0100 xxx[874:136760] Using WKWebView
2019-12-20 12:19:12.955626+0100 xxx874:136760] [CDVTimer][console] 0.215054ms
2019-12-20 12:19:12.956149+0100 xxx[874:136760] [CDVTimer][handleopenurl] 0.254035ms
2019-12-20 12:19:12.964714+0100 xxx[874:136760] [CDVTimer][intentandnavigationfilter] 8.396983ms
2019-12-20 12:19:12.965167+0100 xxx[874:136760] [CDVTimer][gesturehandler] 0.229955ms
2019-12-20 12:19:12.970830+0100 xxx[874:136760] [CDVTimer][file] 5.452037ms
2019-12-20 12:19:12.971308+0100 xxx[874:136760] [CDVTimer][inappbrowser] 0.223994ms
2019-12-20 12:19:12.971499+0100 xxx[874:136760] CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.
2019-12-20 12:19:12.971592+0100 xxx[874:136760] [CDVTimer][uiinappbrowser] 0.149012ms
2019-12-20 12:19:12.971875+0100 xxx[874:136760] [CDVTimer][wkinappbrowser] 0.194073ms

ath0mas · 2019-12-20T16:28:42Z

Not much time to look at it these days so if anyone has a feedback for @Kepro feel free :)

chukwumaokere · 2019-12-22T19:02:08Z

Hi, Sorry to be "that guy" but I'm fairly new at this. I have encountered this issue and I want to use the PR version that has this fix for a client production build I'm working on, but I'm not sure how to specify in some file to pull the version from this PR instead of the regular dependency that's lacking this fix. Any tips?

Thanks in advance!

breautek · 2019-12-22T19:13:02Z

Hi, Sorry to be "that guy" but I'm fairly new at this. I have encountered this issue and I want to use the PR version that has this fix for a client production build I'm working on, but I'm not sure how to specify in some file to pull the version from this PR instead of the regular dependency that's lacking this fix. Any tips?

Thanks in advance!

No problem, there is a first time for everything! I'll provide a step-by-step instructions below.

Fork the inappbrowser plugin to your own account using the "Fork" button on github, on the top-right of the page.
Run git clone <your fork repo url>
Now we need to add the repo we want to merge in form as a new remote. In this case, from neohelden's github. So run git remote add neohelden https://github.com/neohelden/cordova-plugin-inappbrowser.git
Now we can fetch neohelden's changesets. Run git fetch neohelden
Because neohelden made their changes in their master branch, we can merge their master branch into your own fork. Run git merge neohelden/master
Now push the changes your own repo. Run git push
Finally, you can install your version of the plugin by using, cordova plugin add https://yourgithubforkurl

Alternatively, you can just install neohelden's copy by using cordova plugin add https://github.com/neohelden/cordova-plugin-inappbrowser.git which might be a good idea just to test it out before spending the time preparing your own fork, but you're at the mercy of a third-party making unexpected changes, or even deleting the fork/repo altogether, so it's just safer to create your own fork to ensure unexpected changes.

chukwumaokere · 2019-12-22T19:37:12Z

Worked perfectly. You've been a tremendous help, @breautek
Cant thank you enough!

ath0mas · 2019-12-22T20:48:29Z

@beevelop were you able to look at the log @Kepro gets at runtime?
CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.

rajashekaranugu · 2019-12-31T15:25:32Z

Hello All, do we have any update regarding this issue?. Thanks in advance

NiklasMerz · 2019-12-31T15:48:27Z

We are planning a minor release with this merged soon. But this issue still needs some reviews and testing.

…

Hello All, do we have any update regarding this issue?. Thanks in advance — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584?email_source=notifications&email_token=AA3LORCQWBB6E5NLCKSL4RLQ3NP63A5CNFSM4JSJSJQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH4KZVI#issuecomment-569945301>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3LORGJQFBA6FRBKFLQXFLQ3NP63ANCNFSM4JSJSJQQ>.

timbru31 · 2020-01-07T10:06:08Z

@irene-pc - yes, the new release is still in the voting phase and the 48 hours have not yet passed.

See Niklas' second link for the current voting situation (and feel free to test the release and add a non-binding vote)

irene-pc · 2020-01-07T11:55:31Z

@irene-pc - yes, the new release is still in the voting phase and the 48 hours have not yet passed.

See Niklas' second link for the current voting situation (and feel free to test the release and add a non-binding vote)

Thank you so much for the information @timbru31 I'm newbie here and I don't know very well how does updates work and when are they available.

Kepro · 2020-01-08T16:02:40Z

if I use "master" branch and I will use
then I got
2020-01-08 17:01:09.517925+0100 InSight Assess[2441:1535723] [CDVTimer][inappbrowser] 0.198960ms 2020-01-08 17:01:09.518268+0100 InSight Assess[2441:1535723] CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist. 2020-01-08 17:01:09.518376+0100 InSight Assess[2441:1535723] [CDVTimer][uiinappbrowser] 0.271916ms 2020-01-08 17:01:09.518652+0100 InSight Assess[2441:1535723] [CDVTimer][wkinappbrowser] 0.187993ms

nobody else got this issue?

brodycj · 2020-01-08T16:35:46Z

In case of issues with the master branch or upcoming release from npm then please raise a new issue with a minimal, reproducible example. We do not have extra resources to support discussions in merged PRs or closed issues.

irene-pc · 2020-01-08T16:42:41Z

Does anyone know when version 3.2.0 will be available in npm?

NiklasMerz · 2020-01-08T17:01:49Z

This has been answered many times. Please read above. The release is in progress. Please be patient. Asking won't make it faster. Releases are available when they are done. Am 8. Jan. 2020, 17:42, um 17:42, irene-pc <notifications@github.com> schrieb:

…

Does anyone know when version 3.2.0 will be available in npm? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #584 (comment)

brodycj · 2020-01-08T18:44:32Z

FYI we have finished voting on the release and expect to publish it very soon. Please feel free to ping me personally (don't ping any other individuals) in case it really does take too long.

Release discussions and voting threads generally happen on the mailing list. It is also fine to contact us by Slack in case of any questions. Links to find the mailing list and Slack channel are in the footer of cordova.io which redirects to: cordova.apache.org

In general, we would appreciate a reasonable amount of patience since Apache Cordova is maintained by a bunch of generally overworked volunteers. But please do feel free to follow up with us in case of any unreasonable delays.

mjamal4u · 2020-01-08T19:07:37Z

For all incredible contributors on this issue. This release means a lot for our Apps. Thank you !!!

NiklasMerz · 2020-01-08T19:15:16Z

Thank you all here for your patience and testing this PR. I am proud to announce that version 3.2.0 is now available on NPM. The release blog post will be on cordova.apache.org very soon.

irene-pc · 2020-01-09T07:28:53Z

Thank you so much to all of you.

@brodybits thank you so much for your response. I am newbie in the whole process of launching a new version :)

NiklasMerz · 2020-01-09T08:46:08Z

This has been answered many times. Please read above. The release is in progress. Please be patient. Asking won't make it faster. Releases are available when they are done.

@irene-pc Revisiting this comment now, I realised that it could sound rude. That was not my intent and I am sorry about that.

I am new member of the PMC and I am still figuring out how to work on releases. Chris and Tim did a great job to explain how the Cordova community works. I would advise you to join the mailing list to get the latest news.

Thank you all in this thread very much for supporting my first release.

ath0mas · 2020-01-10T09:37:21Z

Released 3.2.0 works perfect, thanks you to all contributors 😍
And congrats @NiklasMerz for your first release! :)

irene-pc · 2020-01-10T09:47:46Z

Hallo @NiklasMerz Nothing happens. It is normal. It's your first release and maybe it is all new for you. You did a great job. My main concern was Apple email and with this update I don't receive it. Thank you so much 👍
I think it is a great idea to join the mailing list. How can I do that?

NiklasMerz · 2020-01-10T09:49:44Z

@irene-pc You can find everything here https://cordova.apache.org/contact/

irene-pc · 2020-01-10T10:10:07Z

@NiklasMerz Thank you

jtibbles · 2020-01-16T16:09:18Z

Thanks @NiklasMerz . Quick question - does the plugin need the platform ios5.1.1 to work or is 5.1.0 sufficient?

NiklasMerz · 2020-01-16T16:20:32Z

This should work with 5.1.0 where WKWebViewOnly was introduced. But version 5.1.1 is just a patch version with just a few fixes you should prefer .

erisu · 2020-01-16T23:59:36Z

@jtibbles @NiklasMerz I would recommend using Cordova-iOS 5.1.1.

In 5.1.0, yes the WKWebViewOnly flag was introduced but there was a bug that caused the cordova platform add ios command to fail when the flag was set in config.xml before adding the platform. See issue ticket for more details: apache/cordova-ios#725

This bug is fixed and released in Cordova-iOS 5.1.1.

timbru31 · 2020-05-07T10:30:48Z

Please seek support on StackOverflow or in our Slack community.

n-elhk · 2020-05-11T09:52:51Z

Hi everyone,
I have the same problem as here: #584 (comment) .

package.json:

"cordova-plugin-ionic-webview": "^4.2.1",
"cordova-plugin-inappbrowser": "^3.2.0",
"cordova-ios": "^5.1.1",

config. xml:
preference name="WKWebViewOnly" value="true"

My error: CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.

Yelles · 2020-05-19T23:22:12Z

Hi everyone,
I have the same problem as here: #584 (comment) .

package.json:
"cordova-plugin-ionic-webview": "^4.2.1",
"cordova-plugin-inappbrowser": "^3.2.0",
"cordova-ios": "^5.1.1",
config. xml:
preference name="WKWebViewOnly" value="true"

My error: CDVPlugin class CDVUIInAppBrowser (pluginName: uiinappbrowser) does not exist.

same for me, any solution ?

NiklasMerz · 2020-05-20T06:22:16Z

Please try deleting the iOS platform and add it again. That should clean stuff up that got lost in the update. Make sure you are using the latest versions of those plugins and platforms.

Locking this because pull requests and issues are not for questions. As Tim said please go to Stack Overflow or Slack.

feat: Add compile-time decision for disabling UIWebView

b269051

breautek mentioned this pull request Dec 2, 2019

cordova-plugin-inappbrowser does not work with latest cordova-ios 5.1.0. build fails with error "Unknown type name 'CDVUIWebViewDelegate'" #587

Closed

This was referenced Dec 5, 2019

iOS - build fails if using "WKWebViewOnly" preference #583

Closed

Depreciated API error from Apple #532

Closed

beevelop mentioned this pull request Dec 5, 2019

UIWebView Strategy for Cordova iOS apache/cordova-discuss#110

Merged

breautek mentioned this pull request Dec 22, 2019

iOS AppFlow Build Errors #596

Closed

3 tasks

erisu added this to the 3.2.0 milestone Dec 24, 2019

erisu added the enhancement label Dec 24, 2019

timbru31 mentioned this pull request Jan 7, 2020

Version 3.2.0 is failed to install #605

Closed

levieu mentioned this pull request Feb 7, 2020

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs dpa99c/cordova-plugin-firebasex#266

Closed

mcastets mentioned this pull request Mar 5, 2020

Plugin is not compatible with iOS from April 2020 mapsplugin/cordova-plugin-googlemaps#2746

Closed

EinfachHans mentioned this pull request Mar 9, 2020

feat: Remove UIWebView Code completely mapsplugin/cordova-plugin-googlemaps#2752

Merged

timbru31 mentioned this pull request Mar 24, 2020

Still getting UIWebView even after updating to cordova-ios 5.1.1 and plugin to 3.2.0 #651

Closed

sxi-uiteam mentioned this pull request May 7, 2020

fix for WKWebViewOnly & fullscreen sxi-uiteam/cordova-plugin-inappbrowser#2

Merged

breautek mentioned this pull request May 7, 2020

breaking: remove UIWebView #635

Merged

apache locked as off-topic and limited conversation to collaborators May 20, 2020

feat: Add compile-time decision for disabling UIWebView #584

feat: Add compile-time decision for disabling UIWebView #584

Conversation

beevelop commented Nov 27, 2019

ath0mas commented Nov 28, 2019

beevelop commented Nov 28, 2019

ath0mas commented Dec 2, 2019

mjamal4u commented Dec 3, 2019

bbialas commented Dec 10, 2019

beevelop commented Dec 10, 2019

NiklasMerz commented Dec 10, 2019

breautek commented Dec 10, 2019

beevelop commented Dec 10, 2019

ath0mas commented Dec 11, 2019

Kepro commented Dec 18, 2019

Kepro commented Dec 19, 2019

ath0mas commented Dec 20, 2019

Kepro commented Dec 20, 2019

Kepro commented Dec 20, 2019

ath0mas commented Dec 20, 2019

chukwumaokere commented Dec 22, 2019 • edited Loading

breautek commented Dec 22, 2019

chukwumaokere commented Dec 22, 2019

ath0mas commented Dec 22, 2019

rajashekaranugu commented Dec 31, 2019

NiklasMerz commented Dec 31, 2019 via email

timbru31 commented Jan 7, 2020

irene-pc commented Jan 7, 2020

Kepro commented Jan 8, 2020

brodycj commented Jan 8, 2020

irene-pc commented Jan 8, 2020

NiklasMerz commented Jan 8, 2020 via email

brodycj commented Jan 8, 2020

mjamal4u commented Jan 8, 2020

NiklasMerz commented Jan 8, 2020

irene-pc commented Jan 9, 2020

NiklasMerz commented Jan 9, 2020

ath0mas commented Jan 10, 2020

irene-pc commented Jan 10, 2020

NiklasMerz commented Jan 10, 2020

irene-pc commented Jan 10, 2020

jtibbles commented Jan 16, 2020

NiklasMerz commented Jan 16, 2020

erisu commented Jan 16, 2020 • edited Loading

timbru31 commented May 7, 2020

n-elhk commented May 11, 2020 • edited Loading

Yelles commented May 19, 2020

NiklasMerz commented May 20, 2020

chukwumaokere commented Dec 22, 2019 •

edited

Loading

erisu commented Jan 16, 2020 •

edited

Loading

n-elhk commented May 11, 2020 •

edited

Loading