Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated requireCordovaModule to require for non-cordova modules (Supp… #2586

Merged
merged 1 commit into from
Mar 28, 2019
Merged

updated requireCordovaModule to require for non-cordova modules (Supp… #2586

merged 1 commit into from
Mar 28, 2019

Conversation

hartherbert
Copy link
Contributor

Changed requireCordovaModule to require for non-cordova-modules

referencing this issue #2581

I tested the changes with cordova 9.0.0 and everything worked as expected.

@evertdespiegeleer
Copy link

Awesome, hope this gets merged soon!

@wf9a5m75 wf9a5m75 merged commit bee92b2 into mapsplugin:multiple_maps Mar 28, 2019
@wf9a5m75
Copy link
Member

@hobbydevs Confirmed. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hartherbert @evertdespiegeleer @wf9a5m75