fix Ellipse Circle Rectangle edit bug fix #1160 #1162 #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
+ Coverage 87.65% 87.67% +0.01%
==========================================
Files 149 149
Lines 14189 14188 -1
==========================================
+ Hits 12438 12439 +1
+ Misses 1751 1749 -2
Continue to review full report at Codecov.
|
deyihu
changed the title
fuzhenn
reviewed
Jul 14, 2020
| const center = geometryToEdit.getCenter(); | ||
| const mouseCoordinate = map.viewPointToCoordinate(targetPoint); | ||
| let wline = new LineString([[center.x, center.y], [mouseCoordinate.x, center.y]]); | ||
| let hline = new LineString([[center.x, center.y], [center.x, mouseCoordinate.y]]); |
There was a problem hiding this comment.
const hline 改为 let hline 是什么原因？ 还能省略掉下面的 wline = hline = null
fuzhenn
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.