Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translator class to handle multiple languages #2131

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Vairgrys
Copy link
Contributor

Added a Javascript Class to start handling Multiple Languages on tools that need the translate of the texts on diferent countrys, currently it only handles language per tool and not on global options.

Currently tools modified
AreaTool

  • units text

image
image
image

DistanceTool

  • units text
  • start text

image
image
image

Added json files to handle the node to access the text translated

  • zh-CN
  • en-US
  • es-MX

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@a4b9f17). Click here to learn what that means.

❗ Current head 48e4efe differs from pull request most recent head 000a795. Consider uploading reports for the commit 000a795 to get more accurate results

Files Patch % Lines
src/lang/translator.js 77.41% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2131   +/-   ##
=========================================
  Coverage          ?   83.61%           
=========================================
  Files             ?      168           
  Lines             ?    18608           
  Branches          ?        0           
=========================================
  Hits              ?    15560           
  Misses            ?     3048           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuzhenn fuzhenn merged commit 7830138 into maptalks:master Dec 19, 2023
@fuzhenn
Copy link
Member

fuzhenn commented Dec 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants