UIMarker Can only be added to the map #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzhenn
requested changes
Dec 21, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2162 +/- ##
==========================================
+ Coverage 83.75% 83.78% +0.03%
==========================================
Files 169 169
Lines 18748 18781 +33
==========================================
+ Hits 15702 15736 +34
+ Misses 3046 3045 -1 ☔ View full report in Codecov by Sentry. |
fuzhenn
requested changes
Dec 22, 2023
src/geometry/Geometry.js
Outdated
| @@ -92,6 +92,7 @@ class Geometry extends JSONAble(Eventable(Handlerable(Class))) { | |||
| if (!isNil(id)) { | |||
| this.setId(id); | |||
| } | |||
| this.isGeometry = true; | |||
There was a problem hiding this comment.
isGeometry和下面的isUI，isLayer都没有用到，应该删除掉
There was a problem hiding this comment.
故意加的，方便后续快速判断一个对象是图层，是图形，还是hi
fuzhenn
requested changes
Dec 22, 2023
src/layer/OverlayLayer.js
Outdated
| @@ -258,6 +263,11 @@ class OverlayLayer extends Layer { | |||
| } | |||
| } | |||
| } | |||
| // geojson to Geometry may be null | |||
| if (!geo) { | |||
| console.error(geo, 'is null'); | |||
There was a problem hiding this comment.
提示也应该写成：
console.error(geo, ' is not invalid geometry to add to layer(' + this.getId() + ') at index:' + i);
fuzhenn
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2161