Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Edit control point support collision #2213

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented Feb 29, 2024

fix #2212

   polygon.startEdit({
                    collision,
                    collisionBufferSize:0,
         
                });

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.03%. Comparing base (0303a2f) to head (bc377ad).
Report is 1 commits behind head on master.

Files Patch % Lines
src/renderer/edit/EditHandle.js 96.15% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
+ Coverage   82.98%   83.03%   +0.04%     
==========================================
  Files         171      171              
  Lines       19156    19197      +41     
==========================================
+ Hits        15897    15940      +43     
+ Misses       3259     3257       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuzhenn
Copy link
Member

fuzhenn commented Mar 5, 2024

可以增加一个测试用例:

  • 调用edit时打开collision,保证逻辑被测试覆盖没有报错
  • 可以在edithandle被碰撞时抛一个事件,判断该事件是否被监听到

@fuzhenn fuzhenn merged commit fc320b4 into maptalks:master Mar 5, 2024
1 check passed
@deyihu deyihu deleted the 2212 branch March 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry Edit control point support collision
3 participants