feat: add progressive rendering option for static jpeg images #1397
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like a good addition. can you run 'npm run lint:js:fix' on this to fix the ci lint error |
Thanks @acalcutt for the heads up, updated the commit. |
|
The only other comment I have is it would be nice if the readme included an example of what it wants for boolean. Does it want [0 or 1] or [true or false] |
|
Thanks, updated! |
acalcutt
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for progessive rendering of static jpeg images via the
formatOptions.In my testing, progressive jpegs were ~2% smaller in filesize than their non-progressive counterparts.
They also 'feel' faster because they become more sharp while loading instead of loading in rows from top to bottom.
Also updated the section in the docs.