Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peter/key get #24

Merged
merged 5 commits into from
Jul 27, 2015
Merged

Peter/key get #24

merged 5 commits into from
Jul 27, 2015

Conversation

kingofirony
Copy link
Contributor

  • Gets keys from server

ecgreb
ecgreb reviewed Jul 27, 2015
View reviewed changes
app/src/main/AndroidManifest.xml
package="com.mapzen.erasermap">
package="com.mapzen.erasermap"
android:versionCode="2"
android:versionName="0.1">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to declare version code and version name here. It gets injected by Gradle at build time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ecgreb added a commit that referenced this pull request Jul 27, 2015
@ecgreb
Merge pull request #24 from mapzen/peter/key_get
dad2a94 
Peter/key get
@ecgreb ecgreb merged commit dad2a94 into master Jul 27, 2015
@ecgreb ecgreb deleted the peter/key_get branch July 27, 2015 21:45
@mjcunningham mjcunningham mentioned this pull request Jul 21, 2016
Closed
@msmollin msmollin mentioned this pull request Aug 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingofirony @ecgreb