Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cryptography's built-in PKCS7 padding functions #7

Closed
wants to merge 1 commit into from

Conversation

tannercollin
Copy link

Using cryptography's built-in padding functions is more readable than manually appending / removing the bytes.

I've tested the changes:

Screenshot

I assign all copyright for the changes to you :)

@maqp
Copy link
Owner

maqp commented Apr 21, 2019

Thank you so much! The 1.19.04 now uses pyca/cryptography's PKCS7 implementation. I apologize I'm not able to trivially merge pull requests. This is because all source files have pinned hashes in the installer, which is signed using an airgapped system. So any update in the source requires updating the installer and its signature at the same time. I've credited you in the update log, I hope that's enough!

@maqp maqp closed this Apr 21, 2019
@tannercollin
Copy link
Author

Absolutely! Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants