A few ARIA updates #732
A few ARIA updates #732
Conversation
…ed to be moved, because Fancytree treats leaf nodes as expanded in the data model
…odel, sometimes not. So let's make the logic robust and first child whether something is a leaf node. If so, remove aria-expanded. Once we know it's not a leaf node, we can use hasChildren as that is reliable.
src/jquery.fancytree.js
Outdated
| @@ -3647,14 +3647,16 @@ $.extend(Fancytree.prototype, | |||
| if( node.expanded ){ | |||
| cnList.push(cn.expanded); | |||
| if(aria){ | |||
| $ariaElem.attr("aria-expanded", true); | |||
| if (hasChildren) { | |||
There was a problem hiding this comment.
Shouldn't this be if ( hasChildren !== false ) since hasChildren() returns undefined for lazy, unexpanded nodes. And we want lazy nodes to have aria-expanded set to false?
dist/src/jquery.fancytree.js
Outdated
| $ariaElem.attr("aria-expanded", true); | ||
| } | ||
| if( aria ){ | ||
| if (hasChildren || (hasChildren === undefined && node.lazy)) { |
There was a problem hiding this comment.
See comment on the /src folder: Here we could use hasChildren !== false instead, since undefined is returned for lazy unloaded nodes.
note: This file change is part of the /dist folder and overwritten in the build process. We only need to edit /src/... files
| } | ||
| // if(aria){ |
| if( node.key && opts.generateIds ){ | ||
| node.li.id = opts.idPrefix + node.key; | ||
| } | ||
| node.span = document.createElement("span"); | ||
| node.span.className = "fancytree-node"; | ||
| if( aria && !node.tr ) { | ||
| $(node.span).attr("role", "treeitem"); |
There was a problem hiding this comment.
Putting on the li will allow level, posinset and setsize to be computed automatically by the browser. However, I am working on a fix for Chrome as it's adding descendant text from the child tree items into the auto-computed name. This is a very important bug that it brought to light. In the meantime, the buggy behavior is not bad in Chrome, so I think we should go with this.
| tabindex = opts.titlesTabbable ? " tabindex='0'" : ""; | ||
|
|
||
| nodeTitle = "<span " + role + " class='fancytree-title'" + | ||
| id + tooltip + tabindex + ">" + |
There was a problem hiding this comment.
A little cleanup
Put important important ARIA on the
<li>element and fix bugs in aria-expanded.