Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install any version of package #49

Closed
3 tasks done
maraf opened this issue Nov 14, 2018 · 9 comments
Closed
3 tasks done

Install any version of package #49

maraf opened this issue Nov 14, 2018 · 9 comments
Assignees
@maraf
Labels
enhancement New feature or request ui Changes to the PackageManager UI
Milestone
v0.8.0

Comments

@maraf
Copy link
Owner

maraf commented Nov 14, 2018 •
edited
Loading

So those cases when user finds that latest version doesn't work and wants to try previous.

TODO:

  • NuGetInstallService.IsInstalled must check version.
  • Update to concrete version on Updates tab.
  • Remove Uninstall and Reinstall buttons from Browser tab.
@maraf maraf added enhancement New feature or request ui Changes to the PackageManager UI labels Nov 14, 2018
@maraf maraf added this to the v0.8.0 milestone Dec 1, 2018
@maraf maraf self-assigned this Dec 13, 2018
maraf added a commit that referenced this issue Dec 13, 2018
@maraf
#49 - Extend IPackage by versions download.
84dd45c
maraf added a commit that referenced this issue Dec 13, 2018
@maraf
#49 - Integration of package versions loading into UI.
0a8aa3f
maraf added a commit that referenced this issue Dec 13, 2018
@maraf
#49 - First working Browser package buttons.
a41d0b4
@maraf
Copy link
Owner Author

maraf commented Dec 15, 2018 •
edited
Loading

Uninstall (and so Reinstall) on Browser tab are quite complicated.
Browser tab doesn't show installed versions. It shows latest available versions. So uninstallation process needs to find correct version first and than remove it.

maraf added a commit that referenced this issue Dec 15, 2018
@maraf
#49 - Checking installed package version before uinstalling.
20083fe 
Until now Uninstall process from Browser tab was trying to remove package that was found.
This could caused problems as that found version could has different content.
After this commit selected package on Browser tab can have all buttons disabled:
- Any version of package is installed, so Install command is not available.
- Selected version can't be uninstalled (or reinstalled) because other one is installed.
This should not be the final solution as it's UX is not good.
maraf added a commit that referenced this issue Dec 16, 2018
@maraf
#49 - Finding installed version of package (by package id).
659cc35
@maraf
Copy link
Owner Author

maraf commented Dec 16, 2018

Looking at some other plugin managers, it seems that most of them use "different view for different actions". Maybe the causes is the same I'm facing here - uninstall plugin has different context that the one present on Browser tab.
Right now I'm thinking of removing Uninstall and Reinstall from Browser tab.

@RussKie
Copy link

RussKie commented Dec 16, 2018

Could you perhaps provide some screenshots to other PMs?

@maraf
Copy link
Owner Author

maraf commented Dec 17, 2018 •
edited
Loading

Here are 4 states from VS extensions manager:

  • List of installed
  • Search results (with selection on not-installed and installed extension)
  • List of available updates

image

And here is the same from Notepad++:

image

@RussKie
Copy link

RussKie commented Dec 17, 2018

Could you share a mock up of how you see it working in your PM?

@maraf
Copy link
Owner Author

maraf commented Dec 17, 2018

The change is not dramatic. I'm only considering removal of Uninstall and Reinstall buttons from the browser tab (as PM doesn't have enough context for them).

When I get to PC I will post screens.

@maraf
Copy link
Owner Author

maraf commented Dec 18, 2018

Comparison of Browser tab in v0.7.2 and current v0.8.0.

packagemanager

@RussKie
Copy link

RussKie commented Dec 18, 2018 via email

maraf added a commit that referenced this issue Dec 18, 2018
@maraf
#49 - Remove Uninstall and Reinstall buttons from Browser tab.
5040add
maraf added a commit that referenced this issue Dec 18, 2018
@maraf
#49 - Changing package icon based on selected version.
9879f1a
maraf added a commit that referenced this issue Dec 18, 2018
@maraf
#49 - Design data for Updates tab.
87ae89a
@maraf maraf closed this as completed Dec 18, 2018
@maraf
Copy link
Owner Author

maraf commented Dec 18, 2018

Nah, update to concrete version is still missing.

@maraf maraf reopened this Dec 18, 2018
maraf added a commit that referenced this issue Dec 19, 2018
@maraf
#49 - Updating to concrete version from Updates tab.
8760f17
@maraf maraf closed this as completed Dec 19, 2018
maraf added a commit that referenced this issue Dec 21, 2018
@maraf
#49 - Align "Other versions" button on the Browser tab the same as on…
cc6ceba 
… the Updates tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraf maraf

Labels
enhancement New feature or request ui Changes to the PackageManager UI
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@RussKie @maraf