MabeEnumPhpstan\EnumDynamicReturnTypeExtension::getTypeFromStaticMethodCall() cant handle static calls on variables #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR
Given following code:
will crash as
MabeEnumPhpstan\EnumDynamicReturnTypeExtension::getTypeFromStaticMethodCall()tries to call$staticCall->class->toString();. This happens cause$staticCall->classcan be bothPhpParser\Node\Name(no problem) but alsoPhpParser\Node\Exprwhich doesn't have thetoString()method.What does this PR do
While not feeling like the perfect solution this PR makes sure that we use the default
Enum::getValues()if we can't statically determine which Enum will be used