final modifier for private method is no longer allowed in PHP8 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
reviewed
Sep 23, 2020
src/Enum.php
Outdated
| @@ -81,7 +81,7 @@ public function __toString(): string | |||
| * @throws LogicException Enums are not cloneable | |||
| * because instances are implemented as singletons | |||
| */ | |||
| final private function __clone() | |||
| private function __clone() | |||
There was a problem hiding this comment.
Should it be final protected then, to prevent overwriting the method?
There was a problem hiding this comment.
Cool. final protected is more better. Let me update.
marc-mabe
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP8 it occurs this warning.
Caused by this PHP8 change https://wiki.php.net/rfc/inheritance_private_methods
privateandfinalmodifiers can't be used both.