Update for PHP 7 + tiny optimization #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "S" instead of "s" in zend_parse_parameters to parse string argument Ensure PHP_MINIT_FUNCTION registers expected constants with predictable values Use long == comparison instead of strcmp to identify requested algorithm Update usage of macros that have changed for PHP7
|
Updated this so it works for PHP7 RC8, opening a pull request just in case you happen to be interested as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "S" instead of "s" in zend_parse_parameters to parse string argument
Ensure PHP_MINIT_FUNCTION registers expected constants with predictable
values
Use long == comparison instead of strcmp to identify requested algorithm
Update usage of macros that have changed for PHP7