-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: excludes the passed path for purposes of matching inclusion/exclusion folders #201
base: main
Are you sure you want to change the base?
Conversation
…usion folders The same folder accessed from a different working directory will include/exclude in the same way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR @Aeolun.
Sorry for the late reply, but can you split the two commits into two different PRs?
I would like to merge the bugfix, and also maybe backport it to other versions.
But for a switch to typescript I had planned to do that with the next major version and am not sure if I rather want to follow the approach of adding type definitions to a js project to define the connections to the outside.
Thank you for your time,
Marc
@@ -1,17 +1,20 @@ | |||
{ | |||
"name": "folder-hash", | |||
"version": "4.0.4", | |||
"name": "@aeolun/folder-hash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep this rename in your fork ;) ?
I would still like to add the first commit and maybe you can create a PR from another branch than the main one?
Then you can keep working on your fork without updating this PR.
"target": "ES2015", | ||
"module": "commonjs", | ||
"moduleResolution": "node" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your fork, I would recommend to enable strict validations to allow fewer ways to trick or work around the type system.
No worries about the delay, you are faster than I often am. I'd strongly suggest not going the way of defining separate type definitions. The biggest benefit to Typescript is reasoning about what happens within your own code (was certainly helpful for me trying to navigate through the unfamiliar code, even if I had to type things first). I'm not sure if and when I'll have time to split them up, so if it doesn't happen on any schedule, feel free to lift just the fix from the PR and include it in one of your own commits. |
The same folder accessed from a different working directory will include/exclude in the same way
Whether I run the script from
/src/bla/bla
, pointing at../../
or from/src
pointing at./
should work the same way when I'm writing an exclusion rule calledexclude: ['bla/bla']
.Originally running it from
/src/bla/bla
would prepend../../
to all the paths.