Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reactive Window data #637

Merged
merged 24 commits into from
Jun 1, 2024
Merged

feat: Reactive Window data #637

merged 24 commits into from
Jun 1, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented May 31, 2024

Depends #635
Closes #636

@marc2332 marc2332 added the enhancement 🔥 New feature or request label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 57.51634% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 73.00%. Comparing base (30e6c59) to head (c9dd362).
Report is 4 commits behind head on main.

Current head c9dd362 differs from pull request most recent head 858f9b4

Please upload reports for the commit 858f9b4 to get more accurate results.

Files Patch % Lines
crates/renderer/src/app.rs 0.00% 25 Missing ⚠️
crates/core/src/platform_state.rs 48.14% 14 Missing ⚠️
crates/renderer/src/event_loop.rs 0.00% 5 Missing ⚠️
crates/hooks/src/use_theme.rs 0.00% 4 Missing ⚠️
crates/renderer/src/accessibility.rs 0.00% 4 Missing ⚠️
crates/hooks/src/use_preferred_theme.rs 0.00% 3 Missing ⚠️
crates/testing/src/test_handler.rs 76.92% 3 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 2 Missing ⚠️
crates/freya/src/launch.rs 0.00% 2 Missing ⚠️
crates/hooks/src/use_init_native_platform.rs 95.45% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   73.60%   73.00%   -0.61%     
==========================================
  Files         192      194       +2     
  Lines       19468    19186     -282     
==========================================
- Hits        14329    14006     -323     
- Misses       5139     5180      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 changed the title feat: Reactive Window state feat: Reactive Window data May 31, 2024
@marc2332 marc2332 marked this pull request as ready for review May 31, 2024 21:37
@marc2332 marc2332 linked an issue May 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Reactive Window data
2 participants