Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text dragging with shift and cursor #642

Merged
merged 15 commits into from
Jun 1, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 1, 2024

Closes #641
Depends on #640

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 1, 2024
@marc2332 marc2332 linked an issue Jun 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 72.94%. Comparing base (128b962) to head (9335338).
Report is 3 commits behind head on main.

Current head 9335338 differs from pull request most recent head b34158b

Please upload reports for the commit b34158b to get more accurate results.

Files Patch % Lines
crates/hooks/src/use_editable.rs 54.34% 42 Missing ⚠️
crates/hooks/src/text_editor.rs 61.53% 10 Missing ⚠️
crates/components/src/input.rs 42.85% 4 Missing ⚠️
crates/hooks/src/editor_history.rs 20.00% 4 Missing ⚠️
crates/hooks/src/rope_editor.rs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   73.00%   72.94%   -0.07%     
==========================================
  Files         192      192              
  Lines       19151    19226      +75     
==========================================
+ Hits        13981    14024      +43     
- Misses       5170     5202      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/delete-text-selection-with-backspace to main June 1, 2024 14:04
@marc2332 marc2332 merged commit e21791d into main Jun 1, 2024
4 checks passed
@marc2332 marc2332 deleted the feat/text-dragging-with-shift-and-cursor branch June 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Support shift + click to select text
1 participant