Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optionally allow inserting tabs as spaces #664

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 8, 2024

Closes #662

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (9d37c3c) to head (24c8295).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/hooks/src/use_editable.rs 57.57% 14 Missing ⚠️
crates/hooks/src/text_editor.rs 0.00% 9 Missing ⚠️
crates/hooks/src/rope_editor.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   73.90%   73.81%   -0.09%     
==========================================
  Files         194      194              
  Lines       19951    19977      +26     
==========================================
+ Hits        14745    14747       +2     
- Misses       5206     5230      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -10,6 +10,7 @@ use crate::{text_editor::*, EditableMode, EditorHistory, HistoryChange};
pub struct RopeEditor {
pub(crate) rope: Rope,
pub(crate) cursor: TextCursor,
pub(crate) identation: usize,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use u8

@marc2332 marc2332 merged commit 90bf13f into main Jun 10, 2024
4 checks passed
@marc2332 marc2332 deleted the feat/optionally-allow-inserting-tabs-as-spaces branch June 10, 2024 19:48
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Optionally add support to write tabs in TextEditor
1 participant