Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support nested routes in ActivableRoute #675

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 8, 2024

Closes #674
Depends on #672

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 215 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (5c0f452) to head (b2fe634).
Report is 3 commits behind head on main.

Current head b2fe634 differs from pull request most recent head 5d8813d

Please upload reports for the commit 5d8813d to get more accurate results.

Files Patch % Lines
crates/devtools/src/tabs/style.rs 0.00% 100 Missing ⚠️
crates/renderer/src/devtools.rs 0.00% 42 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 36 Missing ⚠️
crates/devtools/src/tabs/tree.rs 0.00% 15 Missing ⚠️
crates/devtools/src/hooks/use_node_info.rs 0.00% 7 Missing ⚠️
crates/freya/src/launch.rs 0.00% 6 Missing ⚠️
crates/renderer/src/app.rs 0.00% 6 Missing ⚠️
crates/renderer/src/lib.rs 0.00% 2 Missing ⚠️
crates/devtools/src/node.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   73.90%   74.01%   +0.10%     
==========================================
  Files         194      195       +1     
  Lines       19951    19922      -29     
==========================================
  Hits        14745    14745              
+ Misses       5206     5177      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 linked an issue Jun 9, 2024 that may be closed by this pull request
@marc2332 marc2332 changed the title feat: ActivableRoute now matches nested routes feat: Support nested routes in ActivableRoute Jun 9, 2024
* feat: Persist devtools node inspector routing

* clippy
Base automatically changed from feat/persist-devtools-node-inspector-routing to feat/more-reliable-devtools June 10, 2024 19:32
Base automatically changed from feat/more-reliable-devtools to main June 10, 2024 19:39
@marc2332 marc2332 merged commit 37e6f2d into main Jun 10, 2024
3 checks passed
@marc2332 marc2332 deleted the feat/activable-route-matches-nested-routes branch June 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Support nested routes in ActivableRoute
1 participant