Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing gradient functions #776

Merged
merged 18 commits into from
Aug 3, 2024

Conversation

Aiving
Copy link
Contributor

@Aiving Aiving commented Jul 9, 2024

Closes #773, also closes #774

@Aiving Aiving changed the title Add missing gradient functions feat: Add missing gradient functions Jul 9, 2024
@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 67.21311% with 100 lines in your changes missing coverage. Please review.

Project coverage is 73.90%. Comparing base (c3821a3) to head (9b55129).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/state/src/values/gradient.rs 44.27% 73 Missing ⚠️
crates/core/src/elements/rect.rs 0.00% 18 Missing ⚠️
crates/state/src/values/fill.rs 33.33% 4 Missing ⚠️
crates/core/src/node.rs 0.00% 3 Missing ⚠️
crates/devtools/src/tabs/style.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   73.94%   73.90%   -0.05%     
==========================================
  Files         201      201              
  Lines       21172    21453     +281     
==========================================
+ Hits        15655    15854     +199     
- Misses       5517     5599      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aiving
Copy link
Contributor Author

Aiving commented Jul 9, 2024

@marc2332 I think it is now ready for workflow approval and, if all goes well, for review too.

@Aiving Aiving marked this pull request as ready for review July 10, 2024 17:18
@marc2332 marc2332 self-requested a review July 11, 2024 16:21
Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you update the gradient example to showcase the new two methods tho?

@Aiving
Copy link
Contributor Author

Aiving commented Jul 13, 2024

Oh, okay!

@Aiving
Copy link
Contributor Author

Aiving commented Jul 14, 2024

LGTM. Could you update the gradient example to showcase the new two methods tho?

done!

@marc2332 marc2332 self-requested a review July 15, 2024 21:02
Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about having 1 example instead of 3 hehe

@Aiving
Copy link
Contributor Author

Aiving commented Jul 16, 2024

I was thinking about having 1 example instead of 3 hehe

done!

@marc2332 marc2332 merged commit f4d176e into marc2332:main Aug 3, 2024
3 of 4 checks passed
This was referenced Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Conic Gradient enhancement: Radial Gradients
2 participants