-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add missing gradient functions #776
feat: Add missing gradient functions #776
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 73.94% 73.90% -0.05%
==========================================
Files 201 201
Lines 21172 21453 +281
==========================================
+ Hits 15655 15854 +199
- Misses 5517 5599 +82 ☔ View full report in Codecov by Sentry. |
@marc2332 I think it is now ready for workflow approval and, if all goes well, for review too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you update the gradient example to showcase the new two methods tho?
Oh, okay! |
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about having 1 example instead of 3 hehe
done! |
Closes #773, also closes #774