Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for windows build #293

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

JAicewizard
Copy link
Contributor

No description provided.

@JAicewizard
Copy link
Contributor Author

I am genuinely not sure why github thinks there are over 250 commits here. This is my git log:

commit 24bff14543872826dcc361282635237c90b342f7 (HEAD -> windows, origin/windows)
Author: Jaap Aarts <jaap.aarts1@gmail.com>
Date:   Sun Oct 27 15:37:12 2024 +0100

    Add instructions on how to compile on windows

commit 323b3a97ce6497bd6041157c221cee86de113376
Author: Jaap Aarts <jaap.aarts1@gmail.com>
Date:   Sun Oct 27 13:46:50 2024 +0100

    Log gcc version

commit 7c41608848a85c7925c5123d50f3cc62deb43037 (origin/main, origin/HEAD, main)
Merge: ba0eeb8 b646fbd
Author: tania <44262898+taniabogatsch@users.noreply.github.com>
Date:   Wed Oct 16 09:48:15 2024 +0200

    Merge pull request #201 from JAicewizard/main

    Table function UDFs
...

@JAicewizard JAicewizard changed the base branch from windows to main October 27, 2024 14:45
@JAicewizard
Copy link
Contributor Author

nvm found the issue

@JAicewizard
Copy link
Contributor Author

@yusufozturk if you could check if this works for you?

@yusufozturk
Copy link

Wow thanks @JAicewizard I will check it asap.

@JAicewizard JAicewizard mentioned this pull request Oct 27, 2024
Copy link
Collaborator

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this and expanding the README! Could you remove the binaries? I think the Makefile changes triggered a rebuild on your fork.

Otherwise, once @yusufozturk confirms that this works, we can merge it!

@JAicewizard
Copy link
Contributor Author

I can but I think CI will just add them again, at least it did before. Any way to prevent CI from building them?

@taniabogatsch
Copy link
Collaborator

You should be able to abort the run on your fork under Actions. 🤔
Let me know if that doesn't work.

@JAicewizard
Copy link
Contributor Author

I think they're gone now

@taniabogatsch taniabogatsch merged commit 5177403 into marcboeker:main Oct 28, 2024
12 checks passed
@taniabogatsch
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants