ARRAY type support #306
Merged
ARRAY type support #306
+266
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # vector_setters.go
taniabogatsch
commented
Nov 7, 2024
marcboeker
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@taniabogatsch Thanks for the type addition. I've added some nits as comment.
|
Hi, @marcboeker - thanks for the review! I've implemented your comments and replied to some others! |
marcboeker
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
ARRAYtype.Appending
ARRAYcolumnsThe
Appendercan append both slices and arrays toARRAYcolumns.When passing a slice, the child count must match the array size.
Scanning
ARRAYcolumnsScanning into a slice directly or into a
Compositearray, e.g.,Composite[[3]int32]is possible.