Don't try to import urlconf unless it's a string.

[zenoamaro]

When parsing urls, if request.urlconf is already a module (eg. when using django-subdomains) we shouldn't try to import it.

This checks if urlconf is a string before trying to import it.

[ariovistus]

seems like something that should have a test for it

[zenoamaro]

You're perfectly right. Actually, the urlconf argument wasn't tested directly at all.

This adds tests that pass urlconf directly, both using an import string (and an __import__ mock), or passing a mocked module directly.

I added mock (for mocking imports cleanly) and flake8 (for linting) to requirements.py.

[zenoamaro]

Okay, after a bit of fiddling with tox and requirements (sorry about that, wasn't really familiar with it) this is passing on all environments.

six is now in the requirements (seems like a good idea, actually) as I've used it to test for string types over py2 and py3. Note that I've also left mock in the requirements.py as nose is also there.

[ariovistus]

six seemed like a good idea to me too, but apparently django already packages it in django.util, so use that if you can.

[zenoamaro]

Uh, does GitHub notify on commits or comments only?

[ariovistus]

not sure. thanks for the PR.