Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Page Compression by Default #473

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Conversation

marcingminski
Copy link
Owner

When data compression is enabled post-deployment, the next DACPAC deployment will remove compression unless manual overrides are specified. This complicates deployments in large environments or in cases where the SQLWATCH database is large. From now on, all logger tables are now compressed by default. (If you have no compression enabled and are upgrading to this version, the upgrade can take a while whilst logger data is compressed)

When data compression is enabled post-deployment, the next DACPAC deployment will remove compression unless manual overrides are specified. This complicates deployments in large environments or in cases where the SQLWATCH database is large. From now on, all logger tables are now compressed by default. (If you have no compression enabled and are upgrading to this version, the upgrade can take a while whilst logger data is compressed)
@github-actions github-actions bot added the enhancement New feature or request label Apr 9, 2023
@marcingminski marcingminski merged commit 6c09e63 into main Apr 9, 2023
@marcingminski marcingminski deleted the feature-data-compression branch April 9, 2023 19:02
@Drewster727
Copy link

@marcingminski I am using the following command to install on SQL Server 2017 Standard

Install-DbaSqlWatch -SqlInstance MyInstance -Database SQLWATCH

Getting:

Error SQL72014: Framework Microsoft SqlClient Data Provider: Msg 7738, Level 16, State 2, Line 1 Cannot enable
compression for object 'sqlwatch_logger_agent_job_history'. Only SQL Server Enterprise Edition supports compression.
Error SQL72045: Script execution error.  The executed script:
CREATE TABLE [dbo].[sqlwatch_logger_agent_job_history] (
    [sql_instance]              VARCHAR (32)  NOT NULL,
    [sqlwatch_job_id]           SMALLINT      NOT NULL,
    [sqlwatch_job_step_id]      INT           NOT NULL,
    [sysjobhistory_instance_id] INT           NOT NULL,
    [sysjobhistory_step_id]     INT           NOT NULL,
    [run_duration_s]            REAL          NOT NULL,
    [run_date]                  DATETIME      NOT NULL,
    [run_status]                TINYINT       NOT NULL,
    [snapshot_time]             DATETIME2 (0) NOT NULL,
    [snapshot_type_id]          TINYINT       NOT NULL,
    [run_date_utc]              DATETIME      NOT NULL,
    CONSTRAINT [pk_sqlwatch_logger_agent_job_history] PRIMARY KEY CLUSTERED ([sql_instance] ASC, [snapshot_time] ASC,
[sqlwatch_job_id] ASC, [sqlwatch_job_step_id] ASC, [sysjobhistory_instance_id] ASC, [snapshot_type_id] ASC) WITH
(DATA_COMPRESSION = PAGE)
);

I think it's related to this PR. Happy to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants