Skip to content

Commit

Permalink
Bug 1906853 - add glean probe for http3 udp datagram size r=necko-rev…
Browse files Browse the repository at this point in the history
…iewers,kershaw,janerik

This commit adds four Glean probes:
- http3_udp_datagram_segment_size_sent
- http3_udp_datagram_segment_size_received
- http3_udp_datagram_size_received
- http3_udp_datagram_num_segments_received

Given the performance impact tracking Glean metrics in the UDP hot path, see
https://phabricator.services.mozilla.com/D216034#7453056, this commit introduces
a sample buffer per metric.

This will enable us to measure the impact of:

- Implementation of Packetization Layer Path MTU Discovery for Datagram Transports (RFC 8899) [in Neqo](mozilla/neqo#1903)
- [Fast UDP for Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1901292)

Differential Revision: https://phabricator.services.mozilla.com/D216034

UltraBlame original commit: 16d3f312970444dd8bc8af65629cbef7d7dbcd62
  • Loading branch information
marco-c committed Sep 20, 2024
1 parent 106cf91 commit ee7135b
Show file tree
Hide file tree
Showing 3 changed files with 1,267 additions and 31 deletions.
363 changes: 363 additions & 0 deletions netwerk/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8193,3 +8193,366 @@ com
expires
:
never
http_3_udp_datagram_segment_size_sent
:
type
:
memory_distribution
memory_unit
:
byte
description
:
>
HTTP3
UDP
datagram
segment
size
sent
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
minden
mozilla
.
com
expires
:
never
http_3_udp_datagram_segment_size_received
:
type
:
memory_distribution
memory_unit
:
byte
description
:
>
HTTP3
UDP
datagram
size
received
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
minden
mozilla
.
com
expires
:
never
http_3_udp_datagram_size_received
:
type
:
memory_distribution
memory_unit
:
byte
description
:
>
HTTP3
UDP
datagram
size
received
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
minden
mozilla
.
com
expires
:
never
http_3_udp_datagram_segments_received
:
type
:
custom_distribution
unit
:
integer
range_min
:
0
#
Maximum
number
of
UDP
segments
per
datagram
.
#
#
See
e
.
g
.
Linux
https
:
/
/
github
.
com
/
torvalds
/
linux
/
blob
/
20371ba120635d9ab7fc7670497105af8f33eb08
/
include
/
linux
/
udp
.
h
#
L111
.
range_max
:
128
bucket_count
:
100
histogram_type
:
exponential
description
:
>
HTTP3
UDP
number
of
segments
per
datagram
received
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1906853
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
minden
mozilla
.
com
expires
:
never
Loading

0 comments on commit ee7135b

Please sign in to comment.