Grpc coroutine api updates #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoferrer
force-pushed
the
grpc-coroutine-api-updates
branch
from
ab17b70
to
efe0ae0
Compare
marcoferrer
added a commit
that referenced
this pull request
Feb 18, 2019
* refine api visibility and implement interfaces * remove unused code and annotations in grpc code gen * remove unused response extensions * refactor rpc scope builder to explicit context arg * remove protobuf dependency from coroutine runtime * Default stub coroutine context to `EmptyCoroutineContext` * add scope ext to bind client cancellation handler * implement handleRpc exts * support client cancellation in server rpc builders * simplify client call stub exts * add prototype interface for GrpcServiceDefinition * update changelog
marcoferrer
added a commit
that referenced
this pull request
Feb 18, 2019
This reverts commit c41608c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc API refinements based on production usage of 0.2.2-RC1. This is in preparation for the next release of grpc coroutines.
Still need to add documentation for publicly exposed interfaces