Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to codegen request when file filter is missing #70

Merged
merged 4 commits into from
Aug 31, 2019

Conversation

marcoferrer
Copy link
Owner

At the moment Kroto is ignoring what files are being requested for generation by protoc. The file filtering is purely based on whatever configuration is provided by users.

In order to keep backwards compatibility, kroto should honor existing file filters. But in the event that a file filter is not defined we should fall back to checking the original list of files to generate in the codegen request.

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     85.76%   86.09%   +0.33%     
  Complexity       19       19              
============================================
  Files            15       15              
  Lines           302      302              
  Branches         48       48              
============================================
+ Hits            259      260       +1     
  Misses           15       15              
+ Partials         28       27       -1
Impacted Files Coverage Δ Complexity Δ
...otoplus/coroutines/client/ClientBidiCallChannel.kt 100% <0%> (+4.34%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5aba2...0cda1d3. Read the comment docs.

@marcoferrer marcoferrer merged commit 04c8564 into master Aug 31, 2019
@marcoferrer marcoferrer deleted the file-filter-fix branch September 2, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants