Add support to import a dex client resource, update dexApi #74
Conversation
koendelaat
changed the title
koendelaat
force-pushed
the
import-client-resource
branch
from
5a42259 to
6c3d98b
Compare
|
dexidp/dex#2972 (comment) It seems it isn't officially released yet on the Go API. |
koendelaat
force-pushed
the
import-client-resource
branch
from
6c3d98b to
d11607c
Compare
| github.com/oklog/run v1.0.0/go.mod h1:dlhp/R75TPv97u0XWUtDeV/lRKWPKSdTuV0TZvrmrQA= | ||
| github.com/oklog/run v1.1.0 h1:GEenZ1cK0+q0+wsJew9qUg/DyD8k3JzYsZAi5gYi2mA= | ||
| github.com/oklog/run v1.1.0/go.mod h1:sVPdnTZT1zYwAJeCMu2Th4T21pA3FPOQRfWjQlk7DVU= | ||
| github.com/philips-forks/dex/api/v2 v2.1.1-0.20240826130519-d7839e1fa7b1 h1:nFGgvtcebYXd4yQmJNsJ1UmWy9FiVQ//MPohafgcdKU= |
There was a problem hiding this comment.
Don't want to base this provider on sources from a Fork. We need to work with upstream project to adopt the features from that fork. How does this fork differ from the upstream project? Can't we contribute those changes there? Is there a reason the upstream project didn't adopt those changes?
There was a problem hiding this comment.
Upstream PR: dexidp/dex#3598
| ) | ||
|
|
||
| replace github.com/dexidp/dex/api/v2 v2.1.0 => github.com/philips-forks/dex/api/v2 v2.1.1-0.20240826130519-d7839e1fa7b1 |
There was a problem hiding this comment.
Don't want to base this provider on sources from a Fork. We need to work with upstream project to adopt the features from that fork.
There was a problem hiding this comment.
Upstream PR: dexidp/dex#3598
|
AutoMerged the original #7 earlier when I bumped dependencies and pushed those. I see still few small changes here in yours. Do you feel those changes are required, regarding defaults? |
|
The defaults were configured to fix the test-cases. This remaining default is apparently not required (or the default anyway). PR can be closed. |
Based on #7
New DexIdP release: https://github.com/dexidp/dex/releases/tag/v2.38.0