False positive appointment if "termine" screen is too slow

[mkoderer]

In case the Termine screen is still building up it if statement 1 wrongly matches.

Currently the system seems to be very slow. This is the reason this state could take some seconds:

[mkoderer]

I have a fix for this but I would need to get #29 resolved first.

[ghost]

Bug is still not fixed!

[mkoderer]

Hi @marcoklein, I really believe the logic is incorrect.
It should be logical AND and not OR.
I pushed my latest changes here:
https://github.com/mkoderer/impftermin/commit/004f7b3afcc04175960d33415d449d11d2a162a6

This worked for me at least.. but testing this is really tricky these days.

[marcoklein]

Okay, then I am reopening this issue. I thought the logic worked for me.. Maybe the website has changed?

[marcoklein]

Thanks for your proposed change.. As you say it is hard to test - but looks better with the adjusted logic. I can't test it cause I got no code but I left the debug statements in place. Please let me know if this works now.

[mkoderer]

Thanks - I hope someone could attach the debug log in case of a hit.

[Whindu]

With code the output looks like this:

impftermin:zentrum Performing a check for location with url https://xxx-iz.impfterminservice.de/impftermine/service?plz=xxxxx +30s
impftermin:appointments Checking impf location https://xxx-iz.impfterminservice.de/impftermine/service?plz=xxxxx +267ms
impftermin:appointments We are no longer in the waiting room +673ms
impftermin:appointments Checking with existing code xxxx-xxxx-xxxx +1s
impftermin:appointments No appointments +28s
impftermin:appointments DEBUG: appointmentText=  Derzeit stehen leider keine Termine zur Verfügung.

Die Impfzentren stellen regelmäßig neue Termine ein. Bitte prüfen Sie zu einem späteren Zeitpunkt mit Hilfe Ihres Vermittlungscodes, ob wieder Termine zur Verfügung stehen. +0ms

[Whindu]

With code but too slow web site and wrong assumption an appointment would be available:

impftermin:appointments Checking impf location https://xxx-iz.impfterminservice.de/impftermine/service?plz=xxxxx +378ms
impftermin:appointments We are no longer in the waiting room +6s
impftermin:appointments Checking with existing code xxxx-xxxx-xxxx +1s
impftermin:appointments Appointments available!! +33s
impftermin:appointments DEBUG: appointmentText=undefined +0ms

The site stopped before the klick on the button "Termine suchen"

[mkoderer]

Thanks @Whindu. Have you captured the HTML source by any chance?
I saw this "undefined" appointmentText also for a valid hit.
So better to have a false alert than a missed hit..

@marcoklein unfortunately I would suggest to open the issue again.

[Whindu]

No, only the log output.

[mhl66]

Sorry, there seems to be no reproducible cause (whether the browser window is "slow" or anything). It is very annoying to wake up in the middle of the night.

[mkoderer]

The real annoying thing is that the impfterminservice is absolutely unusable and unreliable these days.
For me it worked over night - could be related to the load of the service.

I tried to debug it today but had no success. I think we need to add more logging to find the root cause.

[marcoklein]

I currently see no effective way of avoiding false positives.. One way might be to check if the 'actual' appointments available page shows up. However, I do not have the HTML for this to implement the necessary steps. The risk with this is also that the impfterminservice.de site changes and you would get false negatives then (so you never get notified).

From my experience the tool yields a couple of appointments (also with code) during the day - however, this highly depends on the locations you choose. I am leaving this open for further discussions but see no effective fix for now.

[mkoderer]

@marcoklein what we could do is log the full html in case of appointmentText == undef.
With that it would be easier to adapt the logic.

[marcoklein]

Yes that would be an option. I'll look into this if I find time but feel free to implement the log change.