Skip to content

Commit

Permalink
add comments to cases definition
Browse files Browse the repository at this point in the history
Ignore the vscode devcontainer configuration
  • Loading branch information
Roberto Ferrer committed Mar 3, 2021
1 parent 0b639e1 commit 94cb6e6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ bin

/.vscode/
/__debug_bin

# Ignore vscode remote-container configuration
/.devcontainer/
dist
6 changes: 6 additions & 0 deletions pkg/assets/assets_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ func TestSanitizeName(t *testing.T) {
out string
}
var cases []sample
//TODO: For sure there will be a better option to divide/adapt tests based on OS
//with this first iteration we can declare scenarios for windows and other OS
//without modifiying the core code of the test.
if runtime.GOOS == "windows" {
cases = []sample{
{"bin_0.0.1_Windows_x86_64.exe","0.0.1","bin.exe"},
Expand Down Expand Up @@ -45,6 +48,9 @@ func TestFilterAssets(t *testing.T) {
out string
}
var cases []sample
//TODO: For sure there will be a better option to divide/adapt tests based on OS
//with this first iteration we can declare scenarios for windows and other OS
//without modifiying the core code of the test.
if runtime.GOOS == "windows"{
cases = []sample {
{args{"bin", []*Asset{
Expand Down

0 comments on commit 94cb6e6

Please sign in to comment.