fix: use first github release in the list as latest when latest is not available #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t available Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
improve-github-latest
branch
from
6e7a26f to
bda3f52
Compare
|
closing since this didn't get too much traction and it has been stale for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @marcosnils!
I wasn't being able to install or update
github.com/weaveworks/tf-controller, so I found this fallback solution for GitHub latest releases which fixes the problem for this repo. The repo does not publish a "latest reference" release, which is whatGetLatestRelease()looks for. But GitHub has thisListReleases()paginated API which lists all the releases starting from the latest (in the common sense meaning of the word, not the "latest reference").Kind regards,